Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 11, 2024

I pushed [email protected] in the BCR.

This provide the MODULE and patch provided there

MODULE.bazel Outdated

module(
name = "skywalking-data-collect-protocol",
version = "10.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have minor changes with versions, I am afraid we don't update this from version to version, because we don't use Brazil internally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove this field or keep it empty.
If you decide to use https://github.com/bazel-contrib/publish-to-bcr it will be updated when you create the new version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have this release plan at there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, what do you prefer then, just remove the field ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will ask our maintainer of cpp SDK to take a look.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbpcode Could you check on this? cpp2sky is the only one using this tool(Brazel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants